[CI][cluster-launcher] release tests that covers autoscaling case #37680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
requested review from
wuisawesome,
DmitriGekhtman,
ericl and
a team
as code owners
jjyao
requested changes
Jul 22, 2023
|
Actually if the cluster.yaml doesn't use docker then by default it's nightly wheel I think |
jjyao
approved these changes
Jul 22, 2023
| @@ -14,3 +14,9 @@ available_node_types: | |||
| resources: {} | |||
| node_config: | |||
| InstanceType: t3.large | |||
| ray.worker.default: | |||
There was a problem hiding this comment.
This one doesn't use docker so I think it's using nightly Ray.
rickyyx
pushed a commit
to rickyyx/ray
that referenced
this pull request
Jul 23, 2023
…y-project#37680) Why are these changes needed? Add release test that both check the cluster is alive, as well as the number of (autoscaled) nodes are expected.
rickyyx
reviewed
Jul 24, 2023
| return "rayproject/ray:nightly-py38" | ||
| elif docker_override == "commit": | ||
| if re.match("^[0-9]+.[0-9]+.[0-9]+$", ray.__version__): | ||
| return f"rayproject/ray:{ray.__version__}.{ray.__commit__[:6]}-py38" |
There was a problem hiding this comment.
so I think this will be using the driver script's ray version? I guess it will be more flexible if we could pass in a commit (or just a docker image) in?
rickyyx
added a commit
that referenced
this pull request
Jul 24, 2023
…7680) (#37692) Why are these changes needed? Add release test that both check the cluster is alive, as well as the number of (autoscaled) nodes are expected. Co-authored-by: Chen Shen <[email protected]>
rickyyx
pushed a commit
to rickyyx/ray
that referenced
this pull request
Jul 26, 2023
…y-project#37680) Why are these changes needed? Add release test that both check the cluster is alive, as well as the number of (autoscaled) nodes are expected.
8 tasks
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…y-project#37680) Why are these changes needed? Add release test that both check the cluster is alive, as well as the number of (autoscaled) nodes are expected. Signed-off-by: NripeshN <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…y-project#37680) Why are these changes needed? Add release test that both check the cluster is alive, as well as the number of (autoscaled) nodes are expected. Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…y-project#37680) Why are these changes needed? Add release test that both check the cluster is alive, as well as the number of (autoscaled) nodes are expected.
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…y-project#37680) Why are these changes needed? Add release test that both check the cluster is alive, as well as the number of (autoscaled) nodes are expected. Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…y-project#37680) Why are these changes needed? Add release test that both check the cluster is alive, as well as the number of (autoscaled) nodes are expected. Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add release test that both check the cluster is alive, as well as the number of (autoscaled) nodes are expected.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.