[docs] turn on fail-on-warning for Sphinx builds #37651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: angelinalg <[email protected]>
|
How could we test it? |
|
I guess need to merge this first? #37628 |
Yeah, for the build to pass.
The fact that the job failed in this PR shows that the change is working as expected. 😄 
|
rkooo567
approved these changes
Jul 21, 2023
angelinalg
added a commit
to angelinalg/ray
that referenced
this pull request
Jul 22, 2023
Signed-off-by: angelinalg <[email protected]>
8 tasks
|
Thanks a lot for following up on this @angelinalg |
bveeramani
added a commit
that referenced
this pull request
Jul 24, 2023
* [Docs] Add V2 ReadTheDocs config (#37590) Signed-off-by: Balaji Veeramani <[email protected]> * turn on fail-on-warning for Sphinx builds (#37651) Signed-off-by: angelinalg <[email protected]> --------- Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: angelinalg <[email protected]> Co-authored-by: Balaji Veeramani <[email protected]>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Signed-off-by: angelinalg <[email protected]> Signed-off-by: NripeshN <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Signed-off-by: angelinalg <[email protected]> Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Signed-off-by: angelinalg <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: angelinalg <[email protected]> Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
Signed-off-by: angelinalg <[email protected]> Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are missing build failures that Sphinx issues warnings for. This flag causes the ReadTheDocs build to fail if Sphinx issues warnings.
cc: @matthewdeng @edoakes @akshay-anyscale @rickyyx @zhe-thoughts
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.