Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][champage] Build champagne cluster environment for both demo and internal account #37646

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jul 21, 2023

Currently we build the champagne environment for only the internal account. Build it both for internal and demo account, so different org (SA, eng, etc.) can use this environment.

Test strategies:

@can-anyscale can-anyscale requested a review from a team as a code owner July 21, 2023 16:29
@can-anyscale can-anyscale marked this pull request as draft July 21, 2023 16:33
@can-anyscale can-anyscale force-pushed the can-champagne-01 branch 2 times, most recently from fa6d992 to 9a7e90c Compare July 21, 2023 21:07
@can-anyscale can-anyscale marked this pull request as ready for review July 21, 2023 21:33
release/ray_release/scripts/ray_champagne.py Outdated Show resolved Hide resolved
"arn:aws:secretsmanager:us-west-2:029272617770:secret:release-automation"
)
ANYSCALE_SECRETS = {
"anyscale-staging-token20221014164754935800000001-pfQunc": (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does the secret names look like this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure; the name is predate my time

@can-anyscale can-anyscale merged commit dc541cd into master Jul 24, 2023
2 checks passed
@can-anyscale can-anyscale deleted the can-champagne-01 branch July 24, 2023 21:15
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants