-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[air][example] Dreambooth fine-tuning example fixes #37504
[air][example] Dreambooth fine-tuning example fixes #37504
Conversation
Signed-off-by: Justin Yu <[email protected]>
…neration process Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Small fix Signed-off-by: Justin Yu <[email protected]>
…examples/dreambooth_batch_fix
Signed-off-by: Justin Yu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Justin! LGTM. Added a few comments.
Maybe in workspace template, we can also add this online inference notebook to let user play with their model interactively with customized prompts. https://github.com/woshiyyya/dreambooth-demo/blob/master/serve.ipynb
…examples/dreambooth_batch_fix
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Release test passed here (see Artifacts for a sample generated image): https://buildkite.com/ray-project/release-tests-pr/builds/46271#01898703-84dd-4596-8240-89a106924b04 Rendered doc updates: https://anyscale-ray--37504.com.readthedocs.build/en/37504/ray-air/examples/dreambooth_finetuning.html |
…ect#37504)" This reverts commit 6ac4521.
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Signed-off-by: NripeshN <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Signed-off-by: harborn <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Signed-off-by: e428265 <[email protected]>
Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Victor <[email protected]>
Why are these changes needed?
This examples makes a few improvements on the dreambooth fine-tuning example:
batch size = 2
."image"
vs"image_1"
columns from a zipped dataset was confusing before)car
(from @woshiyyya's experiments)Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.