[core] Fix a corner case where QueryAllWorkerStates never return #37496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Jul 18, 2023
src/ray/raylet/node_manager.cc
Outdated
| @@ -922,6 +925,9 @@ void NodeManager::QueryAllWorkerStates( | |||
| } | |||
| }); | |||
| } | |||
| if(all_dead) { | |||
There was a problem hiding this comment.
Suggested change
| if(all_dead) { | |
| if (all_dead) { |
|
Wonder if we can also add timeout? |
maybe it's ok. if the worker died, it'll return failure. otherwise, it'll just retry I think? |
|
I think we don't have retry there. One potential problem is the worker being overloaded and never reply, which hangs the reply of the RPC. I don't think we need to handle this in this PR |
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 24, 2023
…-project#37496) In some extreme cases, when the worker becomes dead after getting the workers, the RPC request might never return. This PR fixed this issue.
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
…-project#37496) In some extreme cases, when the worker becomes dead after getting the workers, the RPC request might never return. This PR fixed this issue. Signed-off-by: NripeshN <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…-project#37496) In some extreme cases, when the worker becomes dead after getting the workers, the RPC request might never return. This PR fixed this issue. Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…-project#37496) In some extreme cases, when the worker becomes dead after getting the workers, the RPC request might never return. This PR fixed this issue.
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…-project#37496) In some extreme cases, when the worker becomes dead after getting the workers, the RPC request might never return. This PR fixed this issue. Signed-off-by: e428265 <[email protected]>
vymao
pushed a commit
to vymao/ray
that referenced
this pull request
Oct 11, 2023
…-project#37496) In some extreme cases, when the worker becomes dead after getting the workers, the RPC request might never return. This PR fixed this issue. Signed-off-by: Victor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In some extreme cases, when the worker becomes dead after getting the workers, the RPC request might never return.
This PR fixed this issue.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.