Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Add serve symlink to setup-dev.py #37364

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jul 12, 2023

Why are these changes needed?

Enables dev in workspaces without recompiling.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes edoakes requested review from ericl and a team July 12, 2023 19:09
Signed-off-by: Edward Oakes <[email protected]>
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edoakes edoakes merged commit eddbf62 into ray-project:master Jul 12, 2023
87 of 98 checks passed
Bhav00 pushed a commit to Bhav00/ray that referenced this pull request Jul 24, 2023
Enables dev in workspaces without recompiling.
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
Enables dev in workspaces without recompiling.

Signed-off-by: NripeshN <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Enables dev in workspaces without recompiling.

Signed-off-by: harborn <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Enables dev in workspaces without recompiling.
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Enables dev in workspaces without recompiling.

Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants