[serve] Pin fastapi==0.99.1 in requirements-doc.txt to fix API reference (#37340)
#37354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhe-thoughts
approved these changes
Jul 12, 2023
|
Oops, forgot DCO. Fixed. |
…ference (ray-project#37340) See ray-project#37337 for debugging context. For some reason, `fastapi==0.100.0` breaks the API reference. For now, let's pin it to a working version to fix the docs. We should separately debug and fix the issue. Signed-off-by: Edward Oakes <[email protected]>
|
The windows test failure is relevant: https://buildkite.com/ray-project/oss-ci-build-pr/builds/28438#01894b71-31e4-4ce5-bfa9-a029a3cb4b45/5693-8608 Let's hold off on merging this, I need to first fix it in master. |
|
I think this is technically against policy, but I cherry-picked #37375 as well here (it just adds Given they're tightly related & minimal in scope I figure this is fine. LMK if you want me to split into two PRs (though then the first would break CI in a known way). |
Installs `httpx` so `test_deployment_graph_driver` passes on windows. Signed-off-by: Edward Oakes <[email protected]>
|
Thanks @edoakes for fixing it! I think it's OK in this case. |
|
API ref looks good. Test failures unrelated ( |
bveeramani
merged commit 69d11c0
into
ray-project:releases/2.6.0
109 of 116 checks passed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Cherry-pick #37340
Also cherry-picks: #37375, which is a one-line change to fix the Windows build in CI.
Related issue number
Closes #37337
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.