[dag] Fix the workflow doc code build
#37249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <[email protected]>
edoakes
requested review from
ericl,
fishbone,
stephanie-wang,
suquark,
maxpumperla and
a team
as code owners
Signed-off-by: Edward Oakes <[email protected]>
…workflow-doc-code
Signed-off-by: Edward Oakes <[email protected]>
bveeramani
approved these changes
Jul 10, 2023
Signed-off-by: Edward Oakes <[email protected]>
fishbone
approved these changes
Jul 10, 2023
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 11, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime. Signed-off-by: Bhavpreet Singh <[email protected]>
SongGuyang
pushed a commit
to alipay/ant-ray
that referenced
this pull request
Jul 12, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime. Signed-off-by: 久龙 <[email protected]>
Bhav00
pushed a commit
to Bhav00/ray
that referenced
this pull request
Jul 24, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime. Signed-off-by: Bhavpreet Singh <[email protected]>
NripeshN
pushed a commit
to NripeshN/ray
that referenced
this pull request
Aug 15, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime. Signed-off-by: NripeshN <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime. Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime.
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in ray-project#37198. I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime. Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Previously this code was relying on an implementation detail (DAG nodes not being serializable) to illustrate the point about static DAGs. Serializability was enabled in #37198.
I've updated the code sample to show that the DAG must be constructed statically and returning nodes from other nodes will be evaluated at runtime.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.