Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][fix] bisect needs to read from global config #37157

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

can-anyscale
Copy link
Collaborator

Essentially, all script for running release tests need to read from global config now. I'll need to create an abstract class for these script to inherit from. But that's for another time.

Test strategies:

  • Run bisect job on buildkite

@can-anyscale can-anyscale requested a review from a team as a code owner July 6, 2023 20:02
Copy link
Collaborator Author

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using bazel_runfile to get file path

release/ray_release/scripts/ray_bisect.py Outdated Show resolved Hide resolved
@can-anyscale can-anyscale added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jul 6, 2023
@krfricke krfricke merged commit 47e62f3 into master Jul 7, 2023
2 checks passed
@krfricke krfricke deleted the can-fix-bisect branch July 7, 2023 20:33
SongGuyang pushed a commit to alipay/ant-ray that referenced this pull request Jul 12, 2023
…project#37157)

Essentially, all script for running release tests need to read from global config now. I'll need to create an abstract class for these script to inherit from. But that's for another time.

Signed-off-by: can <[email protected]>
Signed-off-by: 久龙 <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…project#37157)

Essentially, all script for running release tests need to read from global config now. I'll need to create an abstract class for these script to inherit from. But that's for another time.

Signed-off-by: can <[email protected]>
Signed-off-by: harborn <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
…project#37157)

Essentially, all script for running release tests need to read from global config now. I'll need to create an abstract class for these script to inherit from. But that's for another time.

Signed-off-by: can <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…project#37157)

Essentially, all script for running release tests need to read from global config now. I'll need to create an abstract class for these script to inherit from. But that's for another time.

Signed-off-by: can <[email protected]>
Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants