Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/requirements] Remove gluoncv #37129

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Jul 6, 2023

Why are these changes needed?

Following up from #37067, also remove the gluoncv dependency.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz
Copy link
Contributor

pcmoritz commented Jul 6, 2023

Nice, do we also want to remove it from

?

@pcmoritz
Copy link
Contributor

pcmoritz commented Jul 6, 2023

@krfricke Do you still need to do the above removal #37129 (comment) before we merge this?

Signed-off-by: Kai Fricke <[email protected]>
@krfricke krfricke requested a review from a team as a code owner July 7, 2023 00:30
@krfricke
Copy link
Contributor Author

krfricke commented Jul 7, 2023

@krfricke Do you still need to do the above removal #37129 (comment) before we merge this?

I think we can just update this when we do the next periodic update, but yes I've removed it for now

@pcmoritz pcmoritz merged commit 394766d into ray-project:master Jul 7, 2023
111 of 116 checks passed
SongGuyang pushed a commit to alipay/ant-ray that referenced this pull request Jul 12, 2023
Following up from ray-project#37067, also remove the `gluoncv` dependency.

Signed-off-by: 久龙 <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Following up from ray-project#37067, also remove the `gluoncv` dependency.

Signed-off-by: harborn <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
Following up from ray-project#37067, also remove the `gluoncv` dependency.
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Following up from ray-project#37067, also remove the `gluoncv` dependency.

Signed-off-by: e428265 <[email protected]>
@krfricke krfricke deleted the tune/gluoncv-dep branch September 22, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants