Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR] Remove MXNet code #37067

Merged
merged 9 commits into from
Jul 6, 2023
Merged

[AIR] Remove MXNet code #37067

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1f89141
[AIR] Remove MXNet example
pcmoritz Jul 4, 2023
68f9e84
remove
pcmoritz Jul 4, 2023
b9f0f69
remove
pcmoritz Jul 4, 2023
8223671
remove more mxnet stuff
pcmoritz Jul 4, 2023
c21c5a3
update
pcmoritz Jul 4, 2023
4f2cb07
Merge branch 'master' into remove-mxnet-example
pcmoritz Jul 4, 2023
27275b2
rerun
pcmoritz Jul 5, 2023
677c700
Update doc/source/ray-air/predictors.rst
pcmoritz Jul 5, 2023
ce67a32
update
pcmoritz Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions doc/source/_toc.yml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I did a quick search and it seems like there are a few more files where MXNet is being referenced. Shall we remove the rest of them in this PR in order to close #36909?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let me do this -- I don't think the other stuff is useful either :)

Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,6 @@ parts:
title: "PyTorch Example"
- file: tune/examples/tune-pytorch-lightning
title: "PyTorch Lightning Example"
- file: tune/examples/mxnet_example
title: "MXNet Example"
- file: tune/examples/tune-serve-integration-mnist
title: "Ray Serve Example"
- file: tune/examples/pbt_ppo_example
Expand Down
7 changes: 0 additions & 7 deletions doc/source/ray-overview/examples.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,13 +638,6 @@ Ray Examples

How To Tune PyTorch Lightning Models

.. grid-item-card:: :bdg-secondary:`Code example`
:class-item: gallery-item tuning

.. button-ref:: tune-mxnet-example

How To Tune MXNet Models

.. grid-item-card:: :bdg-secondary:`Code example`
:class-item: gallery-item tuning serving

Expand Down
12 changes: 0 additions & 12 deletions doc/source/tune/api/integration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,6 @@ External library integrations for Ray Tune

.. currentmodule:: ray

.. _tune-integration-mxnet:

MXNet (tune.integration.mxnet)
------------------------------

.. autosummary::
:toctree: doc/

~tune.integration.mxnet.TuneReportCallback
~tune.integration.mxnet.TuneCheckpointCallback


.. _tune-integration-pytorch-lightning:

PyTorch Lightning (tune.integration.pytorch_lightning)
Expand Down
8 changes: 0 additions & 8 deletions doc/source/tune/examples/ml-frameworks.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ At the end of these guides you will often find links to even more examples.

How To Tune PyTorch Lightning Models

.. grid-item-card::
:img-top: /images/mxnet_logo.png
:class-img-top: pt-2 w-75 d-block mx-auto fixed-height-img

.. button-ref:: tune-mxnet-example

How To Tune MXNet Models

.. grid-item-card::
:img-top: /images/serve.svg
:class-img-top: pt-2 w-75 d-block mx-auto fixed-height-img
Expand Down
168 changes: 0 additions & 168 deletions doc/source/tune/examples/mxnet_example.ipynb
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions python/ray/tune/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,15 +769,6 @@ py_test(
args = ["--smoke-test"]
)

py_test(
name = "mxnet_example",
size = "small",
srcs = ["examples/mxnet_example.py"],
deps = [":tune_lib"],
tags = ["team:ml", "exclusive", "example"],
args = ["--smoke-test"]
)

py_test(
name = "nevergrad_example",
size = "small",
Expand Down
95 changes: 0 additions & 95 deletions python/ray/tune/examples/mxnet_example.py
View file
Open in desktop

This file was deleted.

Loading