[serve] Enable passing starlette requests w/ a warning #37046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
shrekris-anyscale
approved these changes
Jul 3, 2023
| @@ -45,6 +49,9 @@ | |||
|
|
|||
| logger = logging.getLogger(SERVE_LOGGER_NAME) | |||
|
|
|||
| # Used to only print a single warning when users pass starlette requests via handle. | |||
There was a problem hiding this comment.
Suggested change
| # Used to only print a single warning when users pass starlette requests via handle. | |
| # Used only to print a single warning when users pass starlette requests via handle. |
There was a problem hiding this comment.
The phrasing is as-is to specify that it's used "used to only print a single" versus printing multiple.
Not that this variable is "only used to print" a warning
There was a problem hiding this comment.
Oh got it, could we phrase it like this:
Suggested change
| # Used to only print a single warning when users pass starlette requests via handle. | |
| # Used to print only a single warning when users pass starlette requests via handle. |
There was a problem hiding this comment.
yeah not going to wait for another build for it though, if it fails i'll update it
There was a problem hiding this comment.
That sounds good.
|
Manually tested the microbenchmark locally, working |
SongGuyang
pushed a commit
to alipay/ant-ray
that referenced
this pull request
Jul 12, 2023
…7046) In the new streaming codepath, the starlette.requests.Request object is no longer serializable so it cannot be passed directly via ServeHandle. This is an anti-pattern because the request may not be fully functioning (e.g., detecting disconnects won't work). However, some existing code may rely on it, so in this change we add support by buffering the requests but print a warning message to discourage usage. Signed-off-by: 久龙 <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…7046) In the new streaming codepath, the starlette.requests.Request object is no longer serializable so it cannot be passed directly via ServeHandle. This is an anti-pattern because the request may not be fully functioning (e.g., detecting disconnects won't work). However, some existing code may rely on it, so in this change we add support by buffering the requests but print a warning message to discourage usage. Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…7046) In the new streaming codepath, the starlette.requests.Request object is no longer serializable so it cannot be passed directly via ServeHandle. This is an anti-pattern because the request may not be fully functioning (e.g., detecting disconnects won't work). However, some existing code may rely on it, so in this change we add support by buffering the requests but print a warning message to discourage usage.
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…7046) In the new streaming codepath, the starlette.requests.Request object is no longer serializable so it cannot be passed directly via ServeHandle. This is an anti-pattern because the request may not be fully functioning (e.g., detecting disconnects won't work). However, some existing code may rely on it, so in this change we add support by buffering the requests but print a warning message to discourage usage. Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In the new streaming codepath, the
starlette.requests.Requestobject is no longer serializable so it cannot be passed directly viaServeHandle.This is an anti-pattern because the request may not be fully functioning (e.g., detecting disconnects won't work). However, some existing code may rely on it, so in this change we add support by buffering the requests but print a warning message to discourage usage.
Related issue number
#37027
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.