Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] second try of fixing vllm example in CI #36712

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[CI] second try of fixing vllm example in CI #36712

merged 1 commit into from
Jun 22, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Jun 22, 2023 •
edited
Loading

Why are these changes needed?

fix //doc:source/serve/doc_code/vllm_example failure in CI

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 marked this pull request as ready for review June 22, 2023 18:12
@scv119 scv119 requested a review from a team as a code owner June 22, 2023 18:12
@scv119 scv119 changed the title [vllm] second try of fixing vllm example in CI [CI] second try of fixing vllm example in CI Jun 22, 2023
@scv119
Copy link
Contributor Author

scv119 commented Jun 22, 2023

https://buildkite.com/ray-project/oss-ci-build-pr/builds/26407#0188e45d-5ac0-4960-8664-12e2a6e5c76c passes this time

@scv119 scv119 merged commit 8e45d2d into ray-project:master Jun 22, 2023
1 of 2 checks passed
akshay-anyscale pushed a commit that referenced this pull request Jun 24, 2023
@scv119 @akshay-anyscale
[CI] second try of fixing vllm example in CI #36712
f4de20e 
fix //doc:source/serve/doc_code/vllm_example failure in CI
SongGuyang pushed a commit to alipay/ant-ray that referenced this pull request Jul 12, 2023
@scv119 @SongGuyang
[CI] second try of fixing vllm example in CI ray-project#36712
a9fe565 
fix //doc:source/serve/doc_code/vllm_example failure in CI

Signed-off-by: 久龙 <[email protected]>
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
@scv119 @harborn
[CI] second try of fixing vllm example in CI ray-project#36712
f783ca9 
fix //doc:source/serve/doc_code/vllm_example failure in CI

Signed-off-by: harborn <[email protected]>
harborn pushed a commit to harborn/ray that referenced this pull request Aug 17, 2023
@scv119 @harborn
[CI] second try of fixing vllm example in CI ray-project#36712
028ed7f 
fix //doc:source/serve/doc_code/vllm_example failure in CI
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@scv119 @arvind-chandra
[CI] second try of fixing vllm example in CI ray-project#36712
a8d2d3a 
fix //doc:source/serve/doc_code/vllm_example failure in CI

Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scv119 @matthewdeng