[Core][C++ Worker]Add error message for unsupported Object Ref parameters in C++ Worker #36414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larrylian
requested review from
SongGuyang,
raulchen,
kfstorm and
a team
as code owners
larrylian
force-pushed
the
cpp_worker_unsupport_object_ref
branch
from
9ce1702
to
0cefb70
Compare
SongGuyang
reviewed
Jun 14, 2023
larrylian
force-pushed
the
cpp_worker_unsupport_object_ref
branch
from
0cefb70
to
6318e36
Compare
…ters in C++ Worker Signed-off-by: LarryLian <[email protected]>
larrylian
force-pushed
the
cpp_worker_unsupport_object_ref
branch
from
6318e36
to
912a282
Compare
SongGuyang
pushed a commit
to alipay/ant-ray
that referenced
this pull request
Jul 12, 2023
…ters in C++ Worker (ray-project#36414) Signed-off-by: LarryLian <[email protected]> Signed-off-by: 久龙 <[email protected]>
8 tasks
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…ters in C++ Worker (ray-project#36414) Signed-off-by: LarryLian <[email protected]> Signed-off-by: harborn <[email protected]>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
Aug 17, 2023
…ters in C++ Worker (ray-project#36414) Signed-off-by: LarryLian <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ters in C++ Worker (ray-project#36414) Signed-off-by: LarryLian <[email protected]> Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
C++ Worker currently does not support passing Object Ref parameters, so we are adding an error message to notify users that this functionality is not supported.
C++ Worker will support ObjectRef parameters in the future development.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.