Remove go compiler install on CI #36391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslonnie
force-pushed
the
lonnie-0613-nogo
branch
3 times, most recently
from
e21c6a2
to
11b5a24
Compare
Signed-off-by: Lonnie Liu <[email protected]>
aslonnie
force-pushed
the
lonnie-0613-nogo
branch
from
11b5a24
to
4e733bb
Compare
can-anyscale
approved these changes
Jun 13, 2023
| export PATH="${GOPATH}/bin:${GOROOT}/bin:${PATH}" | ||
| if [[ ! "${OSTYPE}" =~ ^linux ]]; then | ||
| echo "Bazel lint not supported on non-linux systems." | ||
| exit 1 |
There was a problem hiding this comment.
is this function currently called on non-supported system?
There was a problem hiding this comment.
I searched and no. this is only called on ci, and ci only runs lints on linux x86_64.
People can still run the bazel lint directly, which assumes that buildifier is already installed on the system.
Signed-off-by: Lonnie Liu <[email protected]>
vitsai
pushed a commit
to vitsai/ray
that referenced
this pull request
Jun 21, 2023
Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: vitsai <[email protected]>
8 tasks
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place using golang compiler is the buildifier, and we can just download released buildifier binary rather than building from source.