Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Deflake test_http_disconnect #36371

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jun 13, 2023

Why are these changes needed?

test_http_disconnect is flaky because StreamingResponse also calls await request.is_disconnected() and will cancel the generator task when a disconnect occurs.

Updated the test to catch the CancellationError instead which should not be flaky.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Edward Oakes <[email protected]>
@edoakes edoakes requested a review from a team June 13, 2023 15:20
Signed-off-by: Edward Oakes <[email protected]>
@edoakes edoakes merged commit a569a32 into ray-project:master Jun 13, 2023
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
`test_http_disconnect` is flaky because `StreamingResponse` also calls `await request.is_disconnected()` and will cancel the generator task when a disconnect occurs.

Updated the test to catch the `CancellationError` instead which should not be flaky.

Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants