Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] remove import thread #36293

Merged
merged 5 commits into from
Jun 13, 2023
Merged

[core] remove import thread #36293

merged 5 commits into from
Jun 13, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Jun 10, 2023

Why are these changes needed?

import thread is no longer needed, remove it.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 marked this pull request as ready for review June 10, 2023 00:26
@scv119
Copy link
Contributor Author

scv119 commented Jun 10, 2023

@iycheng do we even need function_manager?

@pcmoritz
Copy link
Contributor

There is also join_import_thread in worker.py and def start_import_thread(): that should be removed as well I think :)

Thanks a lot for doing this!!!

@fishbone
Copy link
Contributor

@scv119 function manager is still needed I think. Doc related to this.

Btw, can you confirm that run_functions_on_all_workers have been deprecated? Removing this function will lead that code path failed.

@scv119
Copy link
Contributor Author

scv119 commented Jun 13, 2023

Btw, can you confirm that run_functions_on_all_workers have been deprecated? Removing this function will lead that code path failed.

yup run_functions_on_all_workers is removed from the codebase.

Copy link
Contributor

@fishbone fishbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scv119 scv119 merged commit b737a02 into ray-project:master Jun 13, 2023
pcmoritz added a commit that referenced this pull request Jun 14, 2023
After #36293 is merged we can now fix this.

This fixes #36001 -- I can repro both the hanging and the fact that this PR fixes it on my mac laptop. The rationale for the fix is described in #36109 (comment)
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Why are these changes needed?
import thread is no longer needed, remove it.

Signed-off-by: e428265 <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
After ray-project#36293 is merged we can now fix this.

This fixes ray-project#36001 -- I can repro both the hanging and the fact that this PR fixes it on my mac laptop. The rationale for the fix is described in ray-project#36109 (comment)

Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants