Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoscaler] fix too many values to unpack (expected 2) bug #36231

Merged
merged 4 commits into from
Jun 9, 2023
Merged

[autoscaler] fix too many values to unpack (expected 2) bug #36231

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daca9c1
update
scv119 Jun 8, 2023
dd32bd0
update
scv119 Jun 8, 2023
ad67ec9
update
scv119 Jun 8, 2023
8224db2
fix
scv119 Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@scv119
scv119 committed Jun 8, 2023
commit dd32bd0d604b6b91a65c9fe6369447802b4466b5
15 changes: 9 additions & 6 deletions python/ray/autoscaler/_private/monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,6 @@ def update_resource_requests(self):

def _run(self):
"""Run the monitor loop."""

while True:
try:
gcs_request_start_time = time.time()
Expand Down Expand Up @@ -400,11 +399,15 @@ def _run(self):
self.autoscaler.update()
status["autoscaler_update_time"] = time.time() - update_start_time
autoscaler_summary = self.autoscaler.summary()
self.emit_metrics(
load_metrics_summary,
autoscaler_summary,
self.autoscaler.all_node_types,
)
try:
self.emit_metrics(
load_metrics_summary,
autoscaler_summary,
self.autoscaler.all_node_types,
)
except Exception:
logger.error("Error emitting metrics")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use logger.exception ? or print the stack trace?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to drop the exception silently.


if autoscaler_summary:
status["autoscaler_report"] = asdict(autoscaler_summary)
status[
Expand Down