Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] relax kapa loading scheme #36201

Merged
merged 1 commit into from
Jun 9, 2023
Merged

[docs] relax kapa loading scheme #36201

merged 1 commit into from
Jun 9, 2023

Conversation

maxpumperla
Copy link
Contributor

we had been waiting forever to modify the kapa widget. the problem is that, if that doesn't load, the JS snippet will hang and our docs crash. this PR relaxes that condition.

@maxpumperla maxpumperla requested a review from a team as a code owner June 8, 2023 14:06
@maxpumperla maxpumperla merged commit 7592855 into master Jun 9, 2023
@maxpumperla maxpumperla deleted the mp_relax_kapa branch June 9, 2023 05:53
angelinalg pushed a commit to angelinalg/ray that referenced this pull request Jun 9, 2023
angelinalg pushed a commit to angelinalg/ray that referenced this pull request Jun 9, 2023
maxpumperla added a commit that referenced this pull request Jun 10, 2023
* [Data] [Docs] Ray Data doc changes for 2.5 (#36224)

#35749
#35751
#35753
#35755
#35757
#36018
#36105
#36121
#36144
#36145
#36162
#36124

---------

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
Co-authored-by: Balaji Veeramani <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Co-authored-by: Hao Chen <[email protected]>

* [docs] relax kapa loading scheme (#36201)

Signed-off-by: Max Pumperla <[email protected]>

* Revert "[Data] [Docs] Ray Data doc changes for 2.5 (#36224)"

This reverts commit 48a6c26.

---------

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
Signed-off-by: Max Pumperla <[email protected]>
Co-authored-by: Amog Kamsetty <[email protected]>
Co-authored-by: Balaji Veeramani <[email protected]>
Co-authored-by: Hao Chen <[email protected]>
Co-authored-by: Max Pumperla <[email protected]>
maxpumperla added a commit that referenced this pull request Jun 10, 2023
Signed-off-by: Max Pumperla <[email protected]>
Co-authored-by: Max Pumperla <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants