Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Deflake doctest CI #35999

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Jun 1, 2023

Why are these changes needed?

Doctests are flaky for three reasons:

  • tips-for-first-time.rst is failing because Ray is re-initialized in some examples. This wasn't an issue before because most of the examples were skipped. However, after [Docs] Fix docstring examples with mocked outputs #35928, all of the examples are run. To fix this issue, I've added cleanup code that shutsdown Ray between examples.
  • async_api.rst is flaky because print calls from a previous example manifests in subsequent examples. To avoid flakiness, I've added a short sleep after the example that prints asynchronously.
  • loading-data.rst fails for one of two errors reasons: Either the Python frontend falsely determines that Ray is initialized, so the app complains The core worker process is not initialized yet or already shutdown.; or, the Python frontend thinks Ray isn't initialized and tries to re-init, but the back is actually already initialized. In either case, it seems like the backend and frontend go out of sync. I wasn't able to figure out the underlying issue, so I'm disabling the test for now.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani requested a review from a team as a code owner June 1, 2023 23:24
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jun 2, 2023
@matthewdeng matthewdeng merged commit 55d6e62 into ray-project:master Jun 2, 2023
2 checks passed
@bveeramani bveeramani deleted the deflakt-ci branch June 2, 2023 02:31
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants