[RLlib] break up the learner group tests into shorter tests #35926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
break them up into 3 classes because they all take a very long time to run causing timeouts on master Signed-off-by: Avnish <[email protected]>
avnishn
requested review from
sven1977,
gjoliver,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
…kup_learner_group_tests
Signed-off-by: Avnish <[email protected]>
|
addressed comments |
…earner Signed-off-by: Avnish <[email protected]>
…kup_learner_group_tests
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
kouroshHakha
reviewed
Jun 1, 2023
| @@ -128,7 +128,7 @@ def test_learner_group_local(self): | |||
|
|
|||
| def test_update_multigpu(self): | |||
| fws = ["torch", "tf2"] | |||
| scaling_modes = REMOTE_SCALING_CONFIGS.keys() | |||
| scaling_modes = ["multi-gpu-ddp", "remote-gpu"] | |||
There was a problem hiding this comment.
@avnishn Can you add explanations on why these changes are made? REMOTE_SCALING_CONFIGS.keys() --> ["multi-gpu-ddp", "remote-gpu"]?
There was a problem hiding this comment.
We can reduce the number of tests that we need to run while getting full test coverage by doing this.
kouroshHakha
reviewed
Jun 1, 2023
.buildkite/pipeline.gpu_large.yml
Outdated
| @@ -27,7 +27,7 @@ | |||
| # --jobs 2 is necessary as we only need to have at least 2 gpus on the machine | |||
There was a problem hiding this comment.
comment still says --jobs 2 is necessary
There was a problem hiding this comment.
yep I was exploring here. by removing jobs=2
I'm trying to understand where my cuda oom comes from
Signed-off-by: Avnish <[email protected]>
kouroshHakha
approved these changes
Jun 1, 2023
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
…ect#35926) Signed-off-by: Avnish <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…ect#35926) Signed-off-by: Avnish <[email protected]> Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
break them up into 3 classes because they all take a very long time to run
causing timeouts on master
Signed-off-by: Avnish [email protected]
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.