Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Support auto-init ray for get_runtime_context() #35903

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented May 30, 2023

Why are these changes needed?

Auto init ray when ray.get_runtime_context() is called.

Related issue number

Closes #35889

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao marked this pull request as ready for review May 30, 2023 21:16
Signed-off-by: Jiajun Yao <[email protected]>
@jjyao
Copy link
Collaborator Author

jjyao commented May 31, 2023

Failed tests are unrelated.

Signed-off-by: Jiajun Yao <[email protected]>
@jjyao jjyao merged commit 5511f5f into ray-project:master Jun 1, 2023
@jjyao jjyao deleted the jjyao/auto branch June 1, 2023 03:06
justinvyu pushed a commit to justinvyu/ray that referenced this pull request Jun 1, 2023
…5903)

Auto init ray when ray.get_runtime_context() is called.

Signed-off-by: Jiajun Yao <[email protected]>
scv119 pushed a commit to scv119/ray that referenced this pull request Jun 16, 2023
…5903)

Auto init ray when ray.get_runtime_context() is called.

Signed-off-by: Jiajun Yao <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…5903)

Auto init ray when ray.get_runtime_context() is called.

Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_runtime_context raises confusing AssertionError if Ray is not initialized
2 participants