Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autoscaler v2] test ray-installer #35875

Merged
merged 5 commits into from
May 31, 2023
Merged

[autoscaler v2] test ray-installer #35875

merged 5 commits into from
May 31, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented May 30, 2023

added unit test for ray installer. also add helper function to NodeProviderConfig.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 marked this pull request as ready for review May 30, 2023 08:19
rickyyx
rickyyx approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scv119 scv119 merged commit 68c11a8 into ray-project:master May 31, 2023
1 of 2 checks passed
scv119 added a commit to scv119/ray that referenced this pull request Jun 16, 2023
@scv119
[autoscaler v2] test ray-installer (ray-project#35875)
9a3f5f5 
added unit test for ray installer. also add helper function to NodeProviderConfig.
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@scv119 @arvind-chandra
[autoscaler v2] test ray-installer (ray-project#35875)
33f3af7 
added unit test for ray installer. also add helper function to NodeProviderConfig.

Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyx rickyyx rickyyx approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@DmitriGekhtman DmitriGekhtman Awaiting requested review from DmitriGekhtman

@ericl ericl Awaiting requested review from ericl ericl is a code owner

Assignees

@rickyyx rickyyx

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scv119 @rickyyx @rkooo567