[core][autoscaler] GCS Autoscaler V2: Support autoscaler.sdk.request_resources [5/x] #35846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyyx
commented
May 27, 2023
There was a problem hiding this comment.
The PR is more of a prototype - putting it here early for feedback since I think the current protobuf for cluster resource constraints is not adhering with current autoscaler.sdk.request_resources's semantics.
- There's no per job level resource constraint
- The request resources could be as simple as a list of
ResourceRequest
rickyyx
commented
May 27, 2023
|
as we discussed, let's move ahead with the current implementation and defer the per job design later. |
Signed-off-by: Ricky Xu <[email protected]>
ac17e03
to
f7f33cd
Compare
Signed-off-by: Ricky Xu <[email protected]>
Signed-off-by: Ricky Xu <[email protected]>
scv119
approved these changes
Jun 6, 2023
Signed-off-by: Ricky Xu <[email protected]>
Signed-off-by: Ricky Xu <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…resources [5/x] (ray-project#35846) This PR adds a RPC call RequestClusterResources such that autoscaker.sdk.request_resources will pass the requested resources to GCS directly, which will be passed to autoscaler through GetClusterResourcesState RPC. Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds a RPC call
RequestClusterResourcessuch thatautoscaker.sdk.request_resourceswill pass the requested resources to GCS directly, which will be passed to autoscaler throughGetClusterResourcesStateRPC.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.