[tune] Fix trial runner/controller whitelist attributes #35769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
justinvyu
reviewed
May 26, 2023
| "has_resources_for_trial", | ||
| "pause_trial", | ||
| "save", | ||
| "resource_updater", |
There was a problem hiding this comment.
Suggested change
| "resource_updater", | |
| "_resource_updater", |
There was a problem hiding this comment.
I think this one actually doesn't have a public counterpart.
added 2 commits
May 30, 2023 09:33
Signed-off-by: Kai Fricke <[email protected]>
added 2 commits
May 31, 2023 15:44
Signed-off-by: Kai Fricke <[email protected]>
justinvyu
reviewed
May 31, 2023
| "has_resources_for_trial", | ||
| "pause_trial", | ||
| "save", | ||
| "resource_updater", |
There was a problem hiding this comment.
I think this one actually doesn't have a public counterpart.
added 2 commits
May 31, 2023 21:18
Signed-off-by: Kai Fricke <[email protected]>
justinvyu
approved these changes
Jun 1, 2023
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
…35769) With PBT and BOHB, we currently can get these warnings: ``` 2023-05-24 04:03:59,962 WARNING trial_runner.py:1543 -- You are trying to access pause_trial interface of TrialRunner in TrialScheduler, which is being restricted. If you believe it is reasonable for your scheduler to access this TrialRunner API, please reach out to Ray team on GitHub. A more strict API access pattern would be enforced starting 1.12s.0 ``` While technically we should have seen those warnings before (in the old execution path), it looks like they only come up ever since we activated the new execution path. This PR adds the rest of those attributes we access in our tune-provided schedulers to the whitelist to get rid of the warnings. Signed-off-by: Kai Fricke <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…35769) With PBT and BOHB, we currently can get these warnings: ``` 2023-05-24 04:03:59,962 WARNING trial_runner.py:1543 -- You are trying to access pause_trial interface of TrialRunner in TrialScheduler, which is being restricted. If you believe it is reasonable for your scheduler to access this TrialRunner API, please reach out to Ray team on GitHub. A more strict API access pattern would be enforced starting 1.12s.0 ``` While technically we should have seen those warnings before (in the old execution path), it looks like they only come up ever since we activated the new execution path. This PR adds the rest of those attributes we access in our tune-provided schedulers to the whitelist to get rid of the warnings. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
With PBT and BOHB, we currently can get these warnings:
While technically we should have seen those warnings before (in the old execution path), it looks like they only come up ever since we activated the new execution path.
This PR adds the rest of those attributes we access in our tune-provided schedulers to the whitelist to get rid of the warnings.
Background
We introduced the warnings as preparation to refactor the scheduler interface. We wanted to discourage users to directly call trial runner/executor APIs. The plan was to redefine the interface and get rid of these calls in our own implementations. However, we have deprioritized this effort - that's why we keep a whitelist. We should revisit fixing the scheduler interface in the future.
Related issue number
Addresses part of #35640
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.