[Core] Make "import ray" work without grpcio #35737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
May 25, 2023
| @@ -135,11 +134,13 @@ def set_default_actor_lifetime(self, default_actor_lifetime: str) -> None: | |||
| Args: | |||
| default_actor_lifetime: The default actor lifetime to set. | |||
| """ | |||
| import ray.core.generated.common_pb2 as common_pb2 | |||
There was a problem hiding this comment.
For the protobuf, any special reason we import inside a method?
There was a problem hiding this comment.
This is needed so the docs build is working (some stuff gets mocked there and if this is top level, that prevents things from working). Now that I'm thinking about this, let me actually wrap this use in Cython -- then we can get rid of this import and also wrapping it will be needed anyways going forward when we also want to get rid of the Python protobuf dependency as well :)
| @@ -141,7 +140,7 @@ class PyModulesPlugin(RuntimeEnvPlugin): | |||
|
|
|||
| name = "py_modules" | |||
|
|
|||
| def __init__(self, resources_dir: str, gcs_aio_client: GcsAioClient): | |||
| def __init__(self, resources_dir: str, gcs_aio_client): | |||
There was a problem hiding this comment.
I found a better way now to keep expressing the typing without needing to import the module, updated :)
Co-authored-by: SangBin Cho <[email protected]> Signed-off-by: Philipp Moritz <[email protected]>
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
Why are these changes needed? Import cleanups to push grpc imports out of the critical path of Ray Related issue number Next step in ray-project#35472 Signed-off-by: Philipp Moritz <[email protected]> Co-authored-by: SangBin Cho <[email protected]>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Why are these changes needed? Import cleanups to push grpc imports out of the critical path of Ray Related issue number Next step in ray-project#35472 Signed-off-by: Philipp Moritz <[email protected]> Co-authored-by: SangBin Cho <[email protected]> Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Import cleanups to push
grpcimports out of the critical path of RayRelated issue number
Next step in #35472
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.