Add error details for failed jobs #35691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add error details for failed jobs in the job list view and job detail view 2. Add error details for failed serve apps in the application detail view 3. Fix color of StatusChip for HTTPPRoxy detail page 4. Add max width for error details for Serve deployments Signed-off-by: Alan Guo <[email protected]>
|
lgtm! |
chaowanggg
approved these changes
May 23, 2023
rkooo567
approved these changes
May 23, 2023
architkulkarni
approved these changes
May 23, 2023
|
Can we reduce the width of status message column a bit for job table? It seems that you have to expand to see the useful info for most of the time? |
Signed-off-by: Alan Guo <[email protected]>
|
Reduced width: |
|
LGTM. Thanks! |
|
@alanwguo I'm tracking this now, can you please create the pick after merging? |
alanwguo
added a commit
to alanwguo/ray
that referenced
this pull request
May 24, 2023
Add error details for failed jobs in the job list view and job detail view Add error details for failed serve apps in the application detail view Fix color of StatusChip for HTTPPRoxy detail page Add max width for error details for Serve deployments
8 tasks
ArturNiederfahrenhorst
pushed a commit
that referenced
this pull request
May 25, 2023
Add error details for failed jobs in the job list view and job detail view Add error details for failed serve apps in the application detail view Fix color of StatusChip for HTTPPRoxy detail page Add max width for error details for Serve deployments
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
Add error details for failed jobs in the job list view and job detail view Add error details for failed serve apps in the application detail view Fix color of StatusChip for HTTPPRoxy detail page Add max width for error details for Serve deployments
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
Add error details for failed jobs in the job list view and job detail view Add error details for failed serve apps in the application detail view Fix color of StatusChip for HTTPPRoxy detail page Add max width for error details for Serve deployments Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error details for jobs
Http proxy detail page
Serve Application detail page
Why are these changes needed?
Related issue number
partially addresses #35685
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.