[autoscaler v2] add unit tests for NodeProviderConfig #35590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
requested review from
wuisawesome,
DmitriGekhtman,
ericl and
a team
as code owners
rickyyx
approved these changes
May 22, 2023
| self._calculate_hashes() | ||
| self._sync_continuously = self._node_configs.get( | ||
| "generate_file_mounts_contents_hash", True | ||
| ) | ||
|
|
||
| def _calculate_hashes(self) -> None: | ||
| self._runtime_hash, self._file_mounts_contents_hash = hash_runtime_conf( | ||
| self._node_configs["file_mounts"], | ||
| self._node_configs["cluster_synced_files"], | ||
| self._node_configs.get("file_mounts", {}), |
There was a problem hiding this comment.
I think if we use dataclasses, it will be much easier to validate the config.
rkooo567
approved these changes
May 22, 2023
wooooo Dict[str, Any] |
Pydantic pls |
scv119
added
the
tests-ok
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
) Why are these changes needed? add tests and fix bugs for NodeProviderConfig Signed-off-by: e428265 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
add tests and fix bugs for NodeProviderConfig
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.