Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][autoscaler] GCS Autoscaler V2: Interface [1/x] #35549

Merged
merged 2 commits into from
May 22, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented May 19, 2023

Why are these changes needed?

This PR adds the interface for the AuotscalerStateService for GCS.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Ricky Xu <[email protected]>
@scv119 scv119 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 22, 2023
@scv119
Copy link
Contributor

scv119 commented May 22, 2023

lint error looks related

@rickyyx rickyyx changed the title [core][autoscaler] GCS Autoscaler V2: Interface [1/2] [core][autoscaler] GCS Autoscaler V2: Interface [1/x] May 22, 2023
Signed-off-by: rickyyx <[email protected]>
@rickyyx rickyyx added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels May 22, 2023
@scv119 scv119 merged commit d092f3d into ray-project:master May 22, 2023
2 checks passed
scv119 pushed a commit to scv119/ray that referenced this pull request Jun 16, 2023
)

Why are these changes needed?
This PR adds the interface for the AuotscalerStateService for GCS.
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
)

Why are these changes needed?
This PR adds the interface for the AuotscalerStateService for GCS.

Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants