Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Make doc code snippet testable [4/n] #35506

Merged
merged 3 commits into from
May 18, 2023
Merged

[Doc] Make doc code snippet testable [4/n] #35506

merged 3 commits into from
May 18, 2023

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented May 18, 2023

Why are these changes needed?

Remove # doctest: +SKIP

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao requested a review from a team as a code owner May 18, 2023 17:57
@jjyao
up
b7c05f1 
Signed-off-by: Jiajun Yao <[email protected]>
@cadedaniel cadedaniel mentioned this pull request May 18, 2023
Closed
angelinalg
angelinalg approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjyao @angelinalg
Apply suggestions from code review
28d1660 
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: Jiajun Yao <[email protected]>
@jjyao jjyao merged commit 72205c6 into ray-project:master May 18, 2023
@jjyao jjyao deleted the jjyao/doctest branch May 18, 2023 23:36
scv119 pushed a commit to scv119/ray that referenced this pull request Jun 16, 2023
@jjyao @angelinalg @scv119
[Doc] Make doc code snippet testable [4/n] (ray-project#35506)
9edaa87 
Remove # doctest: +SKIP

Signed-off-by: Jiajun Yao <[email protected]>
Co-authored-by: angelinalg <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@jjyao @angelinalg @arvind-chandra
[Doc] Make doc code snippet testable [4/n] (ray-project#35506)
1e6d398 
Remove # doctest: +SKIP

Signed-off-by: Jiajun Yao <[email protected]>
Co-authored-by: angelinalg <[email protected]>
Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bveeramani bveeramani bveeramani approved these changes

@angelinalg angelinalg angelinalg approved these changes

Assignees

@bveeramani bveeramani

@angelinalg angelinalg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjyao @bveeramani @angelinalg