[docs] batch prediction guide, strict mode #34969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Pumperla <[email protected]>
maxpumperla
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani and
a team
as code owners
ericl
reviewed
May 2, 2023
| @@ -498,6 +497,18 @@ namely Pandas, NumPy, and Arrow, and how they're used in Ray Data: | |||
| :start-after: __simple_numpy_start__ | |||
| :end-before: __simple_numpy_end__ | |||
|
|
|||
| .. tabbed:: Pandas | |||
There was a problem hiding this comment.
Can we remove the entire paragraph above (simple vs tensor vs tabular)? We can replace it saying "NumPy batch format always presents batches as Dict[str, np.ndarray]".
ericl
reviewed
May 2, 2023
doc/source/data/batch_inference.rst
Outdated
| The ``"pandas"`` batch format presents batches in | ||
| `pandas.DataFrame <https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.html>`__ | ||
| format. If converting a simple dataset to Pandas DataFrame batches, a single-column | ||
| dataframe with the column ``"__value__"`` will be created. |
There was a problem hiding this comment.
Remove all mention of __value__ or "single-column" datasets.
amogkam
approved these changes
May 2, 2023
Signed-off-by: amogkam <[email protected]>
|
@ericl your comments are addressed |
ericl
approved these changes
May 2, 2023
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
Signed-off-by: Max Pumperla <[email protected]> Signed-off-by: amogkam <[email protected]> Co-authored-by: amogkam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.