Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Train] LightningTrainer enable checkpoint full dict with FSDP strategy #34967

Merged
merged 6 commits into from
May 5, 2023
Merged

[Train] LightningTrainer enable checkpoint full dict with FSDP strategy #34967

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dda06e9
wip
woshiyyya May 2, 2023
ec3130f
fix lint
woshiyyya May 2, 2023
5beeaad
add error message
woshiyyya May 5, 2023
449d8a5
Merge remote-tracking branch 'upstream/master' into train/lightning_f…
woshiyyya May 5, 2023
02422ab
fix ci
woshiyyya May 5, 2023
c2649cd
fix ci
woshiyyya May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix ci 
Signed-off-by: woshiyyya <[email protected]>
  • Loading branch information
@woshiyyya
woshiyyya committed May 5, 2023
commit 02422abeeb9a2597ef20e1f92d3dbd5deebcb1f8
2 changes: 1 addition & 1 deletion python/ray/train/tests/test_lightning_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ def test_fsdp_checkpoint():

config_builder = (
LightningConfigBuilder()
.module(LinearModule, input_dim=input_dim, output_dim=output_dim)
.module(LinearModule, input_dim=input_dim, output_dim=output_dim, strategy="fsdp")
.trainer(max_epochs=num_epochs, accelerator="gpu")
.strategy("fsdp")
.checkpointing(save_last=True)
Expand Down