Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] crisp chat for kapa.ai integration #34782

Merged
merged 7 commits into from
May 5, 2023
Merged

[docs] crisp chat for kapa.ai integration #34782

merged 7 commits into from
May 5, 2023

Conversation

maxpumperla
Copy link
Contributor

@maxpumperla maxpumperla commented Apr 26, 2023

Preview: https://anyscale-ray--34782.com.readthedocs.build/en/34782/

tomorrow, kapa.ai will finish our custom plugin for this chat interface, then we can use chatgpt for tech support on docs, and optionally loop in human operators.

@maxpumperla maxpumperla requested a review from a team as a code owner April 26, 2023 13:25
Signed-off-by: Max Pumperla <[email protected]>
@pcmoritz
Copy link
Contributor

This is great, thanks for adding this! Maybe it is time now to get rid of the upvote / downvote button since it overlaps with this widget? cc @angelinalg

@maxpumperla
Copy link
Contributor Author

I think we could move one of them, if the upvote system is still useful

@maxpumperla
Copy link
Contributor Author

Screenshot 2023-04-27 at 14 08 56

kapa.ai integration is ready, too

Signed-off-by: Max Pumperla <[email protected]>
@angelinalg
Copy link
Contributor

Cool, @maxpumperla! I talked to @simran-2797 about the layout and she has an idea to make some design improvements. She's going to try something out.

@maxpumperla
Copy link
Contributor Author

@angelinalg I already made some space, but happy to hear Simran's input here

Screenshot 2023-04-27 at 19 16 45

@scottsun94
Copy link
Contributor

Pasted the screenshots on my phone here. Can we avoid the cutoff of the rate-the-doc component and maybe fix the wonky UI when it's collapsed? cc: @simran-2797

IMG_3898
IMG_3899

Here are some instructions about how to update the rate-the-doc component:
The html is here https://github.com/ray-project/rate-the-docs/blob/main/src/widget.html
The CSS is here https://github.com/ray-project/rate-the-docs/blob/main/src/widget.css
Some instructions for how to update it: #26330

Signed-off-by: Max Pumperla <[email protected]>
@angelinalg
Copy link
Contributor

Sync'd with @max and @simran-2797. The data from the "Is this page helpful" CTA is meaningful enough that I'd like to keep it, but we can make the design less intrusive. We'll decouple the design PR from this one so that @maxpumperla can move forward with the Kapa testing. @max can move the CTA all the way to the left for this PR. @simran-2797 will follow up with a PR that improves the design.

Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Max Pumperla <[email protected]>
Signed-off-by: Max Pumperla <[email protected]>
@richardliaw richardliaw merged commit 4714fcd into master May 5, 2023
@richardliaw richardliaw deleted the mp_crisp branch May 5, 2023 16:00
maxpumperla added a commit that referenced this pull request May 5, 2023
richardliaw pushed a commit that referenced this pull request May 5, 2023
maxpumperla added a commit that referenced this pull request May 8, 2023
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants