Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix boto3 pip dependency #34715

Merged
merged 1 commit into from
Apr 25, 2023
Merged

[CI] Fix boto3 pip dependency #34715

merged 1 commit into from
Apr 25, 2023

Conversation

can-anyscale
Copy link
Collaborator

Why are these changes needed?

Most if not all release tests currently have this error spawn in their logs:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. 
--
  | boto3 1.26.117 requires botocore<1.30.0,>=1.29.117, but you have botocore 1.29.105 which is incompatible.

Example: https://buildkite.com/ray-project/release-tests-probes/builds/495#0187aacb-0f8f-440d-a7cf-5dd07b1644ac

This is because test infra re-installs awscli on anyscale, then conflicts with other previously installed packages. Good news is Anyscale already install awscli by default so we can resolve this by removing the installation.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • Testing Strategy
    • Unit tests
    • Release tests

Signed-off-by: Cuong Nguyen <[email protected]>
@can-anyscale can-anyscale marked this pull request as ready for review April 24, 2023 17:25
@can-anyscale can-anyscale requested a review from a team as a code owner April 24, 2023 17:25
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should byod for release tests.. will talk more about this today.

@can-anyscale
Copy link
Collaborator Author

Sound good!

@krfricke krfricke merged commit 2ac4692 into master Apr 25, 2023
@krfricke krfricke deleted the can-fix-pip branch April 25, 2023 18:10
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Jack He <[email protected]>
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants