Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move datastructures in GlobalStateAccessor to Cython #34706

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Apr 24, 2023

Why are these changes needed?

More progress along the lines of #33769 to remove Python gRPC from Ray Core.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@pcmoritz pcmoritz requested a review from a team as a code owner April 24, 2023 08:09
@pcmoritz pcmoritz changed the title [WIP] Move datastructures in GlobalStateAccessor to Cython Move datastructures in GlobalStateAccessor to Cython Apr 24, 2023
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what's the reason behind this change?

@pcmoritz
Copy link
Contributor Author

It's a backport from another branch -- I'm basically uninstalling grpcio, calling ray.init(), seeing what breaks and fixing it. I'm also doing it in such a way that allows us to remove the Python protobuf package going forward (in this case it would have also been possible to reorder some files / imports, but better to do it in such a way that makes it easier to remove Python protobuf going forward).

@pcmoritz pcmoritz merged commit 3e04104 into ray-project:master Apr 26, 2023
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
More progress along the lines of ray-project#33769 to remove Python gRPC from Ray Core.

Signed-off-by: Jack He <[email protected]>
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
More progress along the lines of ray-project#33769 to remove Python gRPC from Ray Core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants