Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workspace templates base image #34684

Merged
merged 1 commit into from
Apr 25, 2023
Merged

update workspace templates base image #34684

merged 1 commit into from
Apr 25, 2023

Conversation

sofianhnaide
Copy link
Contributor

Why are these changes needed?

Update the workspace template base image to use the official Ray 2.4 release.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sofianhnaide sofianhnaide requested a review from a team as a code owner April 21, 2023 22:59
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do I find the build_id? Is it on dockerhub?

Comment on lines 3 to 4
# docker_image: anyscale/ray-ml:latest-py39
# ray_version: nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we use the byod since it has the latest alias?

#   docker_image: anyscale/ray-ml:latest-py39-gpu
#   ray_version: latest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update from discussion with Sofian:

  • Product does not support "anonymous" cluster envs. So, if we do a BYOD solution, then every new template they create will show up as a new cluster env in their cluster envs listing page.
  • So, we'll start with base images build ids.
  • The product code-path already supports BYOD, so it would be easy to transition.

@sofianhnaide
Copy link
Contributor Author

Where do I find the build_id? Is it on dockerhub?

I believe all the config are under "backend/config" in the product repo and they map into docker hub. They do follow the same convention and I included examples for nightly and release versions.

@richardliaw richardliaw merged commit fb58279 into ray-project:master Apr 25, 2023
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants