Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Update quickstart & getting started for explicit Application concept #34673

Merged
merged 5 commits into from
Apr 24, 2023
Merged

[serve] Update quickstart & getting started for explicit Application concept #34673

merged 5 commits into from
Apr 24, 2023

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Apr 21, 2023 •
edited
Loading

Why are these changes needed?

Docs follow up to: #34627

First PR in a series to standardize around the Application concept.

  • Updates quickstarts & getting started w/ relevant verbiage.
  • De-emphasizes deployment graph API (that should be introduced in its own section).

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
quickstart & getting started
c10580d 
Signed-off-by: Edward Oakes <[email protected]>
@edoakes
fix
614a291 
Signed-off-by: Edward Oakes <[email protected]>
@edoakes edoakes requested a review from angelinalg April 21, 2023 19:42
akshay-anyscale
akshay-anyscale approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@akshay-anyscale akshay-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with small nit

doc/source/serve/getting_started.md Outdated Show resolved Hide resolved
@edoakes edoakes merged commit e39efea into ray-project:master Apr 24, 2023
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@edoakes @ProjectsByJackHe
[serve] Update quickstart & getting started for explicit `Application…
9e1603a 
…` concept (ray-project#34673)

Signed-off-by: Jack He <[email protected]>
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@edoakes @architkulkarni
[serve] Update quickstart & getting started for explicit `Application…
9833984 
…` concept (ray-project#34673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sihanwang41 sihanwang41 sihanwang41 approved these changes

@akshay-anyscale akshay-anyscale akshay-anyscale approved these changes

@shrekris-anyscale shrekris-anyscale Awaiting requested review from shrekris-anyscale shrekris-anyscale is a code owner

@zcin zcin Awaiting requested review from zcin zcin is a code owner

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

@angelinalg angelinalg Awaiting requested review from angelinalg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edoakes @sihanwang41 @akshay-anyscale