[CI] fix virtualenv version to deflake linux:https://python/ray/tests:test_runtime_env_complicated #34650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
changed the title
rickyyx
approved these changes
Apr 21, 2023
rkooo567
approved these changes
Apr 21, 2023
jjyao
reviewed
Apr 21, 2023
python/requirements.txt
Outdated
| @@ -18,7 +18,7 @@ pyyaml | |||
| aiosignal | |||
| frozenlist | |||
| requests | |||
| virtualenv>=20.0.24 | |||
| virtualenv>=20.0.24, != 20.21.1 | |||
There was a problem hiding this comment.
Is it a virtualenv bug? Should we do <20.21.1?
There was a problem hiding this comment.
The reasoning is that if it's not their issue then the next virtualenv will also break things.
There was a problem hiding this comment.
i've no idea. let's first see if this deflakes it.
jjyao
approved these changes
Apr 21, 2023
richardliaw
approved these changes
Apr 21, 2023
scv119
added a commit
that referenced
this pull request
Apr 21, 2023
…runtime_env_complicated (#34650) Looks the virtualenv has been upgraded between the success and failed test.
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…runtime_env_complicated (ray-project#34650) Looks the virtualenv has been upgraded between the success and failed test. Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…runtime_env_complicated (ray-project#34650) Looks the virtualenv has been upgraded between the success and failed test. Signed-off-by: Jack He <[email protected]>
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
…runtime_env_complicated (ray-project#34650) Looks the virtualenv has been upgraded between the success and failed test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Looks the virtualenv has been upgraded between the success and failed test.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.