-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Add torch compile capabilities to TorchRLModule #34640
Merged
kouroshHakha
merged 111 commits into
ray-project:master
from
ArturNiederfahrenhorst:torchcompilerlmodules
May 17, 2023
Merged
Changes from 1 commit
Commits
Show all changes
111 commits
Select commit
Hold shift + click to select a range
08a2f7e
Add torch compile to torch RL Module
ArturNiederfahrenhorst 963d2bf
remove spec checks from torch
ArturNiederfahrenhorst e6432e0
initial
ArturNiederfahrenhorst 4453bc0
wip
ArturNiederfahrenhorst 68e7970
Add torch compile test for breaks encountered by dynamo
ArturNiederfahrenhorst a98d296
Add test to BUILD
ArturNiederfahrenhorst ab01b3c
Minor fix
ArturNiederfahrenhorst 13eef89
Merge branch 'master' into removecheckspecsfromdefaultcodepath
ArturNiederfahrenhorst 584f83e
Add only_check_on_retry to tests
ArturNiederfahrenhorst 5cebaf2
typo
ArturNiederfahrenhorst d46ca5f
Kourosh's suggestions
ArturNiederfahrenhorst ee0fac4
Add SpecCheckingError
ArturNiederfahrenhorst 76fb4aa
Fix test spec dict and lint
ArturNiederfahrenhorst 9601e3a
Merge branch 'master' into torchcompilerlmodules
ArturNiederfahrenhorst 849fa7e
Revert experimental changes
ArturNiederfahrenhorst 899e1bc
merge removecheckspecsfromdefaultcodepath
ArturNiederfahrenhorst e554d35
Merge branch 'master' into removecheckspecsfromdefaultcodepath
ArturNiederfahrenhorst 571e02f
Sven's comment
ArturNiederfahrenhorst 6d3ad29
Merge branch 'removecheckspecsfromdefaultcodepath' into torchcompiler…
ArturNiederfahrenhorst f0a9200
Remove aot eager backend
ArturNiederfahrenhorst 53ad1ba
lint
ArturNiederfahrenhorst 987caa8
wip
ArturNiederfahrenhorst 80634a5
wip
ArturNiederfahrenhorst 651ed48
wip
ArturNiederfahrenhorst fc86ae3
wip
ArturNiederfahrenhorst 35da2a0
merge master
ArturNiederfahrenhorst a71cad4
wip
ArturNiederfahrenhorst 0a10f00
merge master
ArturNiederfahrenhorst 1f5386d
remove state specs from ActorCritcEncoder
ArturNiederfahrenhorst 2b0e6af
merge master
ArturNiederfahrenhorst cf19c45
wip
ArturNiederfahrenhorst a912f5f
wip
ArturNiederfahrenhorst 5eb0f01
Fix compiled methods stuck with olds weights after update on workers
ArturNiederfahrenhorst 8e71638
wip
ArturNiederfahrenhorst 4dbfaa5
Merge branch 'master' into torchcompilerlmodules
ArturNiederfahrenhorst c7a4164
move action distributions out of forwards
ArturNiederfahrenhorst 8745439
merge actiondistoutofforwards
ArturNiederfahrenhorst a3887ab
docs
ArturNiederfahrenhorst 35a1ad4
Merge branch 'actiondistoutofforwards' into torchcompilerlmodules
ArturNiederfahrenhorst 1d7d6d3
wip
ArturNiederfahrenhorst f8b3fd3
merge master
ArturNiederfahrenhorst b64727a
lint
ArturNiederfahrenhorst b8ca1ec
merge actiondistoutofforwards
ArturNiederfahrenhorst 682eba0
wip
ArturNiederfahrenhorst 4683f21
merge master
ArturNiederfahrenhorst d11dc42
wip
ArturNiederfahrenhorst 57cf2ac
Merge branch 'master' into actiondistoutofforwards
ArturNiederfahrenhorst d933f6b
Fix missing action distribution conversion
ArturNiederfahrenhorst cbaf353
Add config compilation to rollout worker
ArturNiederfahrenhorst ddd0194
Fix APPOg
ArturNiederfahrenhorst 56684f9
Merge branch 'actiondistoutofforwards' into torchcompilerlmodules
ArturNiederfahrenhorst 51d9a89
Fix torch DDP
ArturNiederfahrenhorst 19f3f3d
Fix torch DDP
ArturNiederfahrenhorst f5ce19f
Merge branch 'actiondistoutofforwards' into torchcompilerlmodules
ArturNiederfahrenhorst 17cdae7
wip
ArturNiederfahrenhorst a640838
fix dunder bug
ArturNiederfahrenhorst fa34ca4
fix assert
ArturNiederfahrenhorst b2a9757
Fix tune issues
ArturNiederfahrenhorst 400b972
wip
ArturNiederfahrenhorst 6ef4110
Add reduce overhead mode
ArturNiederfahrenhorst d9c4b6c
Merge branch 'master' into removesomespecs
ArturNiederfahrenhorst f7c3ef7
wip
ArturNiederfahrenhorst 795f81e
merge master
ArturNiederfahrenhorst 0756a55
Cleanup
ArturNiederfahrenhorst 92d364c
Fix random policy
ArturNiederfahrenhorst 91c4116
Merge branch 'removesomespecs' into torchcompilerlmodules
ArturNiederfahrenhorst d890e9e
more testing
ArturNiederfahrenhorst 9c328bd
Fix GRU and LSTM
ArturNiederfahrenhorst fd40bc0
Merge branch 'removesomespecs' into torchcompilerlmodules
ArturNiederfahrenhorst 1bcf681
fix cnn test
ArturNiederfahrenhorst f18e49a
Merge branch 'removesomespecs' into torchcompilerlmodules
ArturNiederfahrenhorst 04ffd9e
Fix torch import error
ArturNiederfahrenhorst a17433a
merge master
ArturNiederfahrenhorst 2f1ac0d
Merge branch 'removesomespecs' into torchcompilerlmodules
ArturNiederfahrenhorst ab160f7
Add stateful AC encoder
ArturNiederfahrenhorst 0934530
Stop modifying input tensors
ArturNiederfahrenhorst 24e2cf7
Don't omdify state dict in stateful AC encoder
ArturNiederfahrenhorst 9895e67
Minor cleanup
ArturNiederfahrenhorst 5539a58
Merge branch 'removesomespecs' into torchcompilerlmodules
ArturNiederfahrenhorst bfa3fb4
minor change to kick off CI again
ArturNiederfahrenhorst 66650dc
Merge branch 'removesomespecs' into torchcompilerlmodules
ArturNiederfahrenhorst 4af1bf8
Kourosh's comments
ArturNiederfahrenhorst 5106186
Merge branch 'master' into torchcompilerlmodules
ArturNiederfahrenhorst 4cce6f8
Fix missing returng
ArturNiederfahrenhorst 463eddb
Merge branch 'removesomespecs' into torchcompilerlmodules
ArturNiederfahrenhorst b590f4e
wip
ArturNiederfahrenhorst 5428dc6
Fix Torch RL Module
ArturNiederfahrenhorst 38e791d
Add framework warnings
ArturNiederfahrenhorst 32cb3b4
Random change to kick off CI
ArturNiederfahrenhorst 36b2fd0
Kourosh's nit
ArturNiederfahrenhorst e6f4cf4
fix torch check in torch rl Module
ArturNiederfahrenhorst cf7f53f
Merge branch 'removesomespecs' into torchcompilerlmodules
ArturNiederfahrenhorst 38e50b5
Merge branch 'master' into torchcompilerlmodules
ArturNiederfahrenhorst e5d193c
wip
ArturNiederfahrenhorst 4c48f36
introduce compile_wrapper
ArturNiederfahrenhorst 8bcdc28
move torch specific code out of learner
ArturNiederfahrenhorst aa3a679
fix access to _rl_modules
ArturNiederfahrenhorst 9916bad
Fix dependency error
ArturNiederfahrenhorst 816065e
Fix mising torch_compile_cfg
ArturNiederfahrenhorst e600710
typo
ArturNiederfahrenhorst 6a0f260
Merge branch 'master' into torchcompilerlmodules
ArturNiederfahrenhorst ff2e10b
Kourosh's comments
ArturNiederfahrenhorst ca6b55f
Add cuda test
ArturNiederfahrenhorst a9dc1a9
fix from rllib.core.rl_module.torch.torch_compile_config import Torch…
ArturNiederfahrenhorst 88586bf
Fix TORCH_COMPILE_REQUIRED_VERSION usage
ArturNiederfahrenhorst e9f646e
lint
ArturNiederfahrenhorst 2ad0925
test torch dependency fix
ArturNiederfahrenhorst ee55018
Fix TORCH_COMPILE_REQUIRED_VERSION
ArturNiederfahrenhorst 6026027
Fix torch dependency issue
ArturNiederfahrenhorst 9efc512
merge master
ArturNiederfahrenhorst 5def60e
Merge branch 'master' into torchcompilerlmodules
ArturNiederfahrenhorst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add test to BUILD
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
- Loading branch information
commit a98d296cff2332802f41aa0c3f912a51381e636f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a TODO list of tests -- We can add the TODO list now and then do it as part of the whole new stack clean up.