Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] add core team to protobuf owner #34566

Merged
merged 1 commit into from
Apr 19, 2023
Merged

[core] add core team to protobuf owner #34566

merged 1 commit into from
Apr 19, 2023

Conversation

scv119
Copy link
Contributor

@scv119 scv119 commented Apr 19, 2023

Why are these changes needed?

update the right ownership for relative folders

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@scv119 scv119 changed the title [core] add core team to gcs and autoscaler [core] add core team to protobuf owner Apr 19, 2023
@scv119 scv119 marked this pull request as ready for review April 19, 2023 12:40
@scv119 scv119 requested a review from a team April 19, 2023 12:42
@scv119 scv119 merged commit 8c279d5 into ray-project:master Apr 19, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@scv119 @elliottower
[core] add core team to protobuf owner ray-project#34566
cb4aa67 
update the right ownership for relative folders

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@scv119 @ProjectsByJackHe
[core] add core team to protobuf owner ray-project#34566
a546d00 
update the right ownership for relative folders

Signed-off-by: Jack He <[email protected]>
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@scv119 @architkulkarni
[core] add core team to protobuf owner ray-project#34566
c0b0bb6 
update the right ownership for relative folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@ericl ericl

@pcmoritz pcmoritz

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@scv119 @rkooo567 @ericl @pcmoritz