Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIR] Fixed UUID for URI checkpoints #34503

Merged
merged 7 commits into from
Apr 24, 2023
Merged

[AIR] Fixed UUID for URI checkpoints #34503

merged 7 commits into from
Apr 24, 2023

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Apr 17, 2023 •
edited
Loading

Why are these changes needed?

Makes sure that multiple workers downloading the same URI at the same time do not duplicate efforts and data.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

gjoliver
gjoliver approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Yard1
Add test
420be71 
Signed-off-by: Antoni Baum <[email protected]>
@Yard1
Tweak
55aea46 
Signed-off-by: Antoni Baum <[email protected]>
@Yard1 Yard1 marked this pull request as ready for review April 18, 2023 20:20
@Yard1 Yard1 merged commit a522693 into ray-project:master Apr 24, 2023
@Yard1 Yard1 deleted the checkpoint_uri_fixed_uuid branch April 24, 2023 20:23
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@Yard1 @ProjectsByJackHe
[AIR] Fixed UUID for URI checkpoints (ray-project#34503)
7cdd9b3 
* [AIR] Fixed UUID for URI checkpoints

Signed-off-by: Antoni Baum <[email protected]>

* Add test

Signed-off-by: Antoni Baum <[email protected]>

* Tweak

Signed-off-by: Antoni Baum <[email protected]>

* Fix test

Signed-off-by: Antoni Baum <[email protected]>

* More explaination

Signed-off-by: Antoni Baum <[email protected]>

---------

Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Jack He <[email protected]>
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@Yard1 @architkulkarni
[AIR] Fixed UUID for URI checkpoints (ray-project#34503)
2cafa00 
* [AIR] Fixed UUID for URI checkpoints

Signed-off-by: Antoni Baum <[email protected]>

* Add test

Signed-off-by: Antoni Baum <[email protected]>

* Tweak

Signed-off-by: Antoni Baum <[email protected]>

* Fix test

Signed-off-by: Antoni Baum <[email protected]>

* More explaination

Signed-off-by: Antoni Baum <[email protected]>

---------

Signed-off-by: Antoni Baum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjoliver gjoliver gjoliver approved these changes

@krfricke krfricke krfricke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yard1 @gjoliver @krfricke