[ci] Remove scripts duplicates and symlinks except for format.sh #34463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <[email protected]>
ericl
approved these changes
Apr 17, 2023
ericl
added
the
@author-action-required
# Conflicts: # scripts/bazel.py # scripts/bazel_sharding.py # scripts/build-docker-images.py # scripts/build-multinode-image.py # scripts/check-bazel-team-owner.py # scripts/check-test-run.py # scripts/check_import_order.py # scripts/check_minimal_install.py # scripts/clang-tidy-diff.py # scripts/determine_tests_to_run.py # scripts/get_build_info.py # scripts/py_dep_analysis.py # scripts/py_dep_analysis_test.py
8 tasks
krfricke
added a commit
that referenced
this pull request
Apr 18, 2023
#34463 removed the scripts under the `scripts/` directory because all of them should have been symlinks. However, `pytest_checker.py` was an actual script that was not symlinked from the `ci/` directory. This PR restores this script at the correct location in `ci/lint` and adjusts all references to it in the codebase. Signed-off-by: Kai Fricke <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…-project#34463) A year ago, ray-project#23866 moved our CI scripts into a more descriptive folder structure. Files in scripts/ were symlinks to the moved scripts. Even then, CI and documentation did not refer to any scripts in scripts/, with the exception of scripts/format.sh, which is referred to in pull request templates. Recently, ray-project#34340 overwrote some of the symlinks with their actual files. Since almost all of these scripts are only used in CI and not by users and developers, we should just get rid of the symlinks. The exception is format.sh which is actively used by developers. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: elliottower <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ect#34523) ray-project#34463 removed the scripts under the `scripts/` directory because all of them should have been symlinks. However, `pytest_checker.py` was an actual script that was not symlinked from the `ci/` directory. This PR restores this script at the correct location in `ci/lint` and adjusts all references to it in the codebase. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…-project#34463) A year ago, ray-project#23866 moved our CI scripts into a more descriptive folder structure. Files in scripts/ were symlinks to the moved scripts. Even then, CI and documentation did not refer to any scripts in scripts/, with the exception of scripts/format.sh, which is referred to in pull request templates. Recently, ray-project#34340 overwrote some of the symlinks with their actual files. Since almost all of these scripts are only used in CI and not by users and developers, we should just get rid of the symlinks. The exception is format.sh which is actively used by developers. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Jack He <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ect#34523) ray-project#34463 removed the scripts under the `scripts/` directory because all of them should have been symlinks. However, `pytest_checker.py` was an actual script that was not symlinked from the `ci/` directory. This PR restores this script at the correct location in `ci/lint` and adjusts all references to it in the codebase. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
A year ago, #23866 moved our CI scripts into a more descriptive folder structure. Files in
scripts/were symlinks to the moved scripts. Even then, CI and documentation did not refer to any scripts inscripts/, with the exception ofscripts/format.sh, which is referred to in pull request templates.Recently, #34340 overwrote some of the symlinks with their actual files. Since almost all of these scripts are only used in CI and not by users and developers, we should just get rid of the symlinks. The exception is
format.shwhich is actively used by developers.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.