Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event ]Fix incorrect event timestamp #34402

Merged
merged 3 commits into from
Apr 18, 2023
Merged

[Event ]Fix incorrect event timestamp #34402

merged 3 commits into from
Apr 18, 2023

Conversation

rkooo567
Copy link
Contributor

Why are these changes needed?

We didn't use the correct system clock + always used UTC timestamp, which is bad. It fixes the issue.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 merged commit 781b811 into ray-project:master Apr 18, 2023
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@rkooo567 @elliottower
[Event ]Fix incorrect event timestamp (ray-project#34402)
cc0bc5e 
We didn't use the correct system clock + always used UTC timestamp, which is bad. It fixes the issue.

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@rkooo567 @ProjectsByJackHe
[Event ]Fix incorrect event timestamp (ray-project#34402)
afc9268 
We didn't use the correct system clock + always used UTC timestamp, which is bad. It fixes the issue.

Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyx rickyyx rickyyx approved these changes

Assignees

@rickyyx rickyyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rkooo567 @rickyyx