Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Make applications required in multi-app config #34401

Merged
merged 5 commits into from
May 4, 2023
Merged

[serve] Make applications required in multi-app config #34401

merged 5 commits into from
May 4, 2023

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Apr 14, 2023

Why are these changes needed?

Make applications required in multi-app config.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zcin
make applications required
82effa1 
Signed-off-by: Cindy Zhang <[email protected]>
sihanwang41
sihanwang41 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@sihanwang41 sihanwang41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have unit tests to deploy with empty list of applications?

@zcin
Copy link
Contributor Author

zcin commented Apr 14, 2023

Do we have unit tests to deploy with empty list of applications?

Just added one!

@zcin
Copy link
Contributor Author

zcin commented May 4, 2023

@edoakes this one should be ready for merge as well

@edoakes edoakes merged commit e238269 into ray-project:master May 4, 2023
architkulkarni pushed a commit to architkulkarni/ray that referenced this pull request May 16, 2023
@zcin @architkulkarni
[serve] Make applications required in multi-app config (ray-project#3…
674e495 
…4401)

Make applications required in multi-app config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sihanwang41 sihanwang41 sihanwang41 approved these changes

@edoakes edoakes edoakes approved these changes

@shrekris-anyscale shrekris-anyscale Awaiting requested review from shrekris-anyscale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcin @sihanwang41 @edoakes