Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Cosmetic changes to Arrow Tensor __repr__ #34286

Merged
merged 8 commits into from
Apr 13, 2023

Conversation

pcmoritz
Copy link
Contributor

Why are these changes needed?

Make it clear what the data type actually is -- a numpy array. Also make the argument ordering consistent between the two types.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@ericl
Copy link
Contributor

ericl commented Apr 12, 2023

I think the tests look ok, but probably should rebase and try again to be sure. A lot are failing with some core build error.

@pcmoritz
Copy link
Contributor Author

Yeah, I was planning to wait merging this until the docs build is green again on master to make sure there is not more breakage introduced by this. Let me look into what still needs to be fixed for the doc build :)

@pcmoritz pcmoritz merged commit 4b0224e into ray-project:master Apr 13, 2023
vitsai pushed a commit to vitsai/ray that referenced this pull request Apr 17, 2023
Make it clear what the data type actually is -- a numpy array. Also make the argument ordering consistent between the two types.
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
Make it clear what the data type actually is -- a numpy array. Also make the argument ordering consistent between the two types.

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
Make it clear what the data type actually is -- a numpy array. Also make the argument ordering consistent between the two types.

Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants