[Serve] Add default app name #34260
Merged
[Serve] Add default app name #34260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihanwang41
force-pushed
the
default_app_name
branch
from
2b82c43
to
ca09fdb
Compare
sihanwang41
force-pushed
the
default_app_name
branch
2 times, most recently
from
4ffd1e0
to
6a94454
Compare
|
The documentation test should be fixed by merging in recent changes |
edoakes
reviewed
Apr 24, 2023
| @@ -29,7 +29,7 @@ | |||
| DEFAULT_GRPC_PORT = 9000 | |||
|
|
|||
| #: Default Serve application name | |||
| SERVE_DEFAULT_APP_NAME = "" | |||
| SERVE_DEFAULT_APP_NAME = "DEFAULT_RAY_SERVE_APP" | |||
There was a problem hiding this comment.
this is potentially user facing so this name is a bit ugly, should we just make it "default" ?
sihanwang41
force-pushed
the
default_app_name
branch
from
a80e53a
to
0e24f6a
Compare
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
Signed-off-by: sihanwang41 <[email protected]>
sihanwang41
force-pushed
the
default_app_name
branch
from
0e24f6a
to
dead823
Compare
edoakes
approved these changes
Apr 25, 2023
|
test failure is not related to serve. |
sihanwang41
added
the
tests-ok
architkulkarni
added a commit
that referenced
this pull request
Apr 25, 2023
This reverts commit 9928085.
|
Hi, this PR seems to cause the compatibility test in KubeRay failing consistently. See #34799 for more details. Thanks! |
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Add default name for applications deploy. Fix a bug for not setting the deployment name correctly for function deployment. Fix unit tests because of the default application name change. Signed-off-by: Jack He <[email protected]>
architkulkarni
pushed a commit
to architkulkarni/ray
that referenced
this pull request
May 16, 2023
Add default name for applications deploy. Fix a bug for not setting the deployment name correctly for function deployment. Fix unit tests because of the default application name change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.