[data] Add take_batch API for collecting data in the same format as iter_batches and map_batches #34217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Liang <[email protected]>
c21
reviewed
Apr 10, 2023
Signed-off-by: Eric Liang <[email protected]>
amogkam
approved these changes
Apr 10, 2023
Signed-off-by: Eric Liang <[email protected]>
Signed-off-by: Eric Liang <[email protected]>
ericl
commented
Apr 10, 2023
Signed-off-by: Eric Liang <[email protected]>
Signed-off-by: Eric Liang <[email protected]>
|
Let's also update the API documentation - https://github.com/ray-project/ray/blob/master/doc/source/data/api/dataset.rst?plain=1#L87 . Thanks. |
Signed-off-by: Eric Liang <[email protected]>
c21
approved these changes
Apr 10, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…ter_batches and map_batches (ray-project#34217) There isn't any convenient way to take just a single batch today, which is confusing. Introduce ds.take_batch(n, batch_format="default"), which returns a batch of n records as next(ds.iter_batches(batch_size=n, batch_format="default")) would. Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…ter_batches and map_batches (ray-project#34217) There isn't any convenient way to take just a single batch today, which is confusing. Introduce ds.take_batch(n, batch_format="default"), which returns a batch of n records as next(ds.iter_batches(batch_size=n, batch_format="default")) would. Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There isn't any convenient way to take just a single batch today, which is confusing. Introduce
ds.take_batch(n, batch_format="default"), which returns a batch ofnrecords asnext(ds.iter_batches(batch_size=n, batch_format="default"))would.TODO:
Closes #34116