Cherry-pick Serve lightweight config update telemetry #34070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhe-thoughts
approved these changes
Apr 5, 2023
|
@zcin can you fix DCO? Also are these failures related: https://buildkite.com/ray-project/oss-ci-build-pr/builds/17450#01874e1c-060b-42f0-b3e6-e4419a2ffc18 |
This change adds new telemetry to get more insight into if and how users are using the lightweight config updates feature of Serve. It adds the telemetry tags: - `SERVE_NUM_REPLICAS_UPDATED`: whether `num_replicas` was updated (without any heavyweight option updated) - `SERVE_USER_CONFIG_UPDATED`: whether `user_config` was updated (without any heavyweight option updated) - `SERVE_AUTOSCALING_CONFIG_UPDATED`: whether `autoscaling_config` was updated (without any heavyweight option updated) These values are set to True as long as the user uses the feature at least once for any deployment in any application on the cluster. Signed-off-by: Cindy Zhang <[email protected]>
Fixed!
No, these failures are unrelated to this PR and also failing on master. I have a fix for the gradio docs tests but it's only a docs examples fix and doesn't affect Ray, so shouldn't need to cherry pick it in unless we want to get rid of the red tests on the release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Cherry pick #34039
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.