Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release tests] Revert all core tests to use anyscale runner #33512 #33657

Merged
merged 2 commits into from
Mar 24, 2023
Merged

[Release tests] Revert all core tests to use anyscale runner #33512 #33657

merged 2 commits into from
Mar 24, 2023

Conversation

rkooo567
Copy link
Contributor

Why are these changes needed?

Due to some regression, we temporarily used V1 for running core tests. This PR moves all core tests that have no performance regression back to the V2 stack. For many actors & many tasks, the active investigation is in progress.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 mentioned this pull request Mar 24, 2023
Closed
8 tasks
jjyao
jjyao approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just reopen the other one and merge it.

@rkooo567 rkooo567 merged commit 77a42d8 into ray-project:master Mar 24, 2023
scottsun94 pushed a commit to scottsun94/ray that referenced this pull request Mar 28, 2023
@rkooo567 @scottsun94
Revert all core tests to use anyscale runner (ray-project#33657)
ef00c8d 
Signed-off-by: SangBin Cho <[email protected]>

Due to some regression, we temporarily used V1 for running core tests. This PR moves all core tests that have no performance regression back to the V2 stack. For many actors & many tasks, the active investigation is in progress.
cassidylaidlaw pushed a commit to cassidylaidlaw/ray that referenced this pull request Mar 28, 2023
@rkooo567 @cassidylaidlaw
Revert all core tests to use anyscale runner (ray-project#33657)
fb1ed71 
Signed-off-by: SangBin Cho <[email protected]>

Due to some regression, we temporarily used V1 for running core tests. This PR moves all core tests that have no performance regression back to the V2 stack. For many actors & many tasks, the active investigation is in progress.
brycehuang30 pushed a commit to brycehuang30/ray that referenced this pull request Mar 29, 2023
@rkooo567 @brycehuang30
Revert all core tests to use anyscale runner (ray-project#33657)
74ea0f0 
Signed-off-by: SangBin Cho <[email protected]>

Due to some regression, we temporarily used V1 for running core tests. This PR moves all core tests that have no performance regression back to the V2 stack. For many actors & many tasks, the active investigation is in progress.


Signed-off-by: bhuang <[email protected]>
joncarter1 pushed a commit to joncarter1/ray that referenced this pull request Apr 2, 2023
@rkooo567 @joncarter1
Revert all core tests to use anyscale runner (ray-project#33657)
afe65d3 
Signed-off-by: SangBin Cho <[email protected]>

Due to some regression, we temporarily used V1 for running core tests. This PR moves all core tests that have no performance regression back to the V2 stack. For many actors & many tasks, the active investigation is in progress.

Signed-off-by: Jonathan Carter <[email protected]>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@rkooo567 @elliottower
Revert all core tests to use anyscale runner (ray-project#33657)
8a5c500 
Signed-off-by: SangBin Cho <[email protected]>

Due to some regression, we temporarily used V1 for running core tests. This PR moves all core tests that have no performance regression back to the V2 stack. For many actors & many tasks, the active investigation is in progress.

Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@rkooo567 @ProjectsByJackHe
Revert all core tests to use anyscale runner (ray-project#33657)
6335458 
Signed-off-by: SangBin Cho <[email protected]>

Due to some regression, we temporarily used V1 for running core tests. This PR moves all core tests that have no performance regression back to the V2 stack. For many actors & many tasks, the active investigation is in progress.

Signed-off-by: Jack He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao jjyao approved these changes

@Yard1 Yard1 Yard1 approved these changes

@krfricke krfricke Awaiting requested review from krfricke

@simon-mo simon-mo Awaiting requested review from simon-mo

Assignees

@jjyao jjyao

@Yard1 Yard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rkooo567 @jjyao @Yard1