Release Performance Regression 2.3.0/2.3.1 #33187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cindy Zhang <[email protected]>
rickyyx
reviewed
Mar 10, 2023
| "large_object_size": 107374182400, | ||
| "large_object_time": 325.56598805499993, | ||
| "large_object_time": 490.7879660510001, |
There was a problem hiding this comment.
what are the PRs we have cherry picked since 2.3.0?
There was a problem hiding this comment.
There was a problem hiding this comment.
I think this is the one with very high variance on the V1 stack due to EBS. I think we should run it again to be sure that it's a regression and not just network tail latency.
There was a problem hiding this comment.
Synced with @rickyyx @cadedaniel, the metrics difference is believed to just be the expected variance. Kicked off a rerun of tests single_node and microbenchmark here and here so that we can be more confident in this hypothesis. @scv119
There was a problem hiding this comment.
thanks @zcin, yeah let's retry here!
scv119
approved these changes
Mar 10, 2023
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
Output from compare_perf_metrics: https://docs.google.com/spreadsheets/d/1lSCLAQ7ghc4uOk80L3e9S2Rxuy7a2d3nbJRPi9D7brM/edit#gid=0 Signed-off-by: Jack He <[email protected]>
cadedaniel
pushed a commit
to cadedaniel/ray
that referenced
this pull request
Mar 22, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Output from compare_perf_metrics: https://docs.google.com/spreadsheets/d/1lSCLAQ7ghc4uOk80L3e9S2Rxuy7a2d3nbJRPi9D7brM/edit#gid=0 Signed-off-by: Edward Oakes <[email protected]>
clarng
pushed a commit
to clarng/ray
that referenced
this pull request
Mar 23, 2023
scottsun94
pushed a commit
to scottsun94/ray
that referenced
this pull request
Mar 28, 2023
cassidylaidlaw
pushed a commit
to cassidylaidlaw/ray
that referenced
this pull request
Mar 28, 2023
chaowanggg
pushed a commit
to chaowanggg/ray-dev
that referenced
this pull request
Apr 4, 2023
Output from compare_perf_metrics: https://docs.google.com/spreadsheets/d/1lSCLAQ7ghc4uOk80L3e9S2Rxuy7a2d3nbJRPi9D7brM/edit#gid=0 Signed-off-by: chaowang <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
Output from compare_perf_metrics: https://docs.google.com/spreadsheets/d/1lSCLAQ7ghc4uOk80L3e9S2Rxuy7a2d3nbJRPi9D7brM/edit#gid=0 Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
Output from compare_perf_metrics: https://docs.google.com/spreadsheets/d/1lSCLAQ7ghc4uOk80L3e9S2Rxuy7a2d3nbJRPi9D7brM/edit#gid=0 Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Output from
compare_perf_metrics:https://docs.google.com/spreadsheets/d/1lSCLAQ7ghc4uOk80L3e9S2Rxuy7a2d3nbJRPi9D7brM/edit#gid=0
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.